Implemented a luma() function call #591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 would love to see this get added |
|
Yes! This would be perfect to use with my #730 contrast function, which does indeed use lightness for this exact purpose. Edit: I did't see your code attached, duh, sorry. |
Closed
|
A different implementation of luma has been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deciding whether to use white/black text on top of a given background color is much better decided using the backgrounds "luma" rather than "lightness". Luma is a better measure of the intensity of the light, since it differentiates between colors that we do not see as well (30% red, 59% green, 11% blue).