Highlight private packages in updated/publish output #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the error in appveyor looks like a problem with the build-cache 😢 |
gigabo
approved these changes
Dec 13, 2016
There was a problem hiding this comment.
Thanks for making these all consistent @chrishelgert!
I've kicked off a re-run in AppVeyor. IMO this is ready to go once that finishes.
| @@ -231,7 +232,8 @@ export default class PublishCommand extends Command { | |||
| this.logger.newLine(); | |||
| this.logger.info("Changes:"); | |||
| this.logger.info(this.updates.map((update) => { | |||
| return `- ${update.package.name}: ${update.package.version} => ${this.updatesVersions[update.package.name]}`; | |||
| const pkg = update.package; | |||
| return `- ${pkg.name}: ${pkg.version} => ${this.updatesVersions[pkg.name]}${pkg.isPrivate() ? ` (${chalk.red("private")})` : ""}`; | |||
There was a problem hiding this comment.
Yeah, sees nicer to have it at the end like this. 👍
|
my pleasure 😃 |
|
Heh, well... AppVeyor passed, but it looks like this has a conflict with #386 which just merged before it. @chrishelgert Please rebase when you get a chance and we'll get this in! |
|
@gigabo so no conflicts with base branch :) |
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #431, this PR adds the styled private annotations for updated and publish-command.
i wasn´t really sure about the position of private in the publish-command, but i think, this solution looks a litte bit nicer.
If you like it otherway, i can change the position :)