Add --ignore-scripts flag to bootstrap command #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evocateur
approved these changes
Jan 21, 2018
| @@ -228,7 +229,7 @@ class BootstrapCommand extends Command { | |||
| } | |||
|
|
|||
| /** | |||
| * Run the "prepublish" NPM script in all bootstrapped packages | |||
| * Run the "prepare" NPM script in all bootstrapped packages | |||
evocateur
changed the title
evocateur
pushed a commit
that referenced
this pull request
Jan 21, 2018
|
@evocateur any chance to have this landed in v2 line? |
|
@evocateur do you know when this PR is going to be published? |
This was referenced Feb 15, 2018
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is quite a simple change - as in the title of the PR.
Motivation and Context
Fixes #1178 . Our packages have configured lifecycle scripts, but having them ran during bootstrap in monorepo only takes time for us. We later use source files between packages within webpack, jest etc (by aliasing packages).
How Has This Been Tested?
Snapshot test was added.
Types of changes
Checklist: