Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code missed by lint settings #1048

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Clean up code missed by lint settings #1048

merged 1 commit into from
Oct 5, 2017

Conversation

jiverson
Copy link
Contributor

@jiverson jiverson commented Oct 5, 2017

Description

Minor cleanup

Motivation and Context

Cause I am anal

How Has This Been Tested?

No need.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

evocateur
evocateur approved these changes Oct 5, 2017
View reviewed changes
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A contribution after my own heart 😍

(I'm disturbed the linting didn't catch most of these, gonna have to look at that)

@evocateur evocateur changed the title Minor cleanup Clean up code missed by lint settings Oct 5, 2017
@evocateur evocateur merged commit 8d99786 into lerna:master Oct 5, 2017
@jiverson
Copy link
Contributor Author

jiverson commented Oct 5, 2017

Yeah I was going to look into that as well just didn't have time atm.

@jiverson jiverson deleted the cleanup branch October 5, 2017 16:55
@evocateur
Copy link
Member

No worries, I'm probably gonna jump on the prettier bandwagon in this repo soon enough.

@dependencies dependencies bot mentioned this pull request Oct 6, 2017
Merged
@dependencies dependencies bot mentioned this pull request Nov 17, 2017
Closed
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evocateur evocateur evocateur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiverson @evocateur