Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block_quote prefix on empty lines too #390

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

patrick91
Copy link
Contributor

I notice that when a blockquote has an empty line it wouldn't be rendered properly, as it would be broken in two blockquotes, from:

> abc
> 
> abc

to

> abc

> abc

Which are rendered differently in html:

abc

abc

and:

abc

abc

@lepture
Copy link
Owner

lepture commented Aug 26, 2024

Hi, thanks for the fix. Can you add a test case for it?

@lepture
Copy link
Owner

lepture commented Aug 29, 2024

@patrick91 thanks for your patch. But the tests are failed. Can you have take a look at the errors?

@patrick91
Copy link
Contributor Author

@lepture done, the tests are passing locally, I had to rstrip the last > to make it work properly 😊

@lepture lepture merged commit bf54ef6 into lepture:master Nov 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants