chore: pin wasm-bindgen to 0.2.93 (does this fix example builds?) #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We regularly need to update
cargo-leptosto matchwasm-bindgenversion updates, as they declare their format incompatible between patch releases.Unfortunately they also made breaking changes to
wasm-bindgen-cli-supportin 0.2.94 such thatcargo-leptosno longer compiles, which means it will take us longer to updatecargo-leptosthan usual.This means all our examples won't compile (because they pull in 0.2.94), and user code won't unless they pin to
=0.2.93. For now, I'm going to try pinning to=0.2.93inleptositself in the hope this will resolve that.I opened an issue on
wasm-bindgenbut I don't anticipate particularly swift action there. I suspect we'll just need to deopt what cargo-leptos does there a bit and make a new release.rustwasm/wasm-bindgen#4159