Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to await child process to avoid race conditions #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

njdancer
Copy link

Found an issue with this plugin where occasionally, some of the outputs of these tasks were not yet available by the time the subsequent build step ran.

This seems to be a result of the way the child process is called. Vite will accept a promise as a return value and subsequently await the promise before proceeding. This update modifies the execute command to be async and await all of the child processes it creates. This is technically a breaking change as there may be some users that rely on the existing behaviour. For this reason, an await option has also been added so that this behaviour can be opted in to. I would consider making this the default at some point in the future however, as I think its what most users will want and expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants