Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Inertia\Support\Header constants instead of strings #74

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

onlime
Copy link

@onlime onlime commented Sep 26, 2024

Using Inertia's Header constants and introducing Momentum Modal ModalHeader constants.

Introduce ModalHeader constants
Migrated deprecated PHPUnit XML schema
Copy link

what-the-diff bot commented Sep 26, 2024

PR Summary

  • Improved Test Configuration
    • The testing configuration has been updated to a newer version. Additionally, the settings for what code parts are covered by testing have been simplified, now covering all the main source code.
  • Refined User Interface Class
    • The class handling the user interface has been tweaked for better clarity and easy maintenance. It now uses constants instead of plain text, ensuring consistency and reducing chances of error.
  • Introduced Modal Header Class
    • A new class has been designed to carry key definitions for interfaces. This provides a single source of truth for these definitions and allows for better organization.
  • Improved Test File Consistency
    • How headers are referred to in the test file has been standardized, using constant definitions from the aforementioned classes. This promotes consistency in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant