Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add component: Column and Section #39

Closed
niloysikdar opened this issue Jun 30, 2022 · 0 comments · Fixed by #46
Closed

add component: Column and Section #39

niloysikdar opened this issue Jun 30, 2022 · 0 comments · Fixed by #46
Assignees
Labels
3 3 story points GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022

Comments

@niloysikdar
Copy link
Member

Description:

  • Add components - Column & Section

Outcome:

  • New Column and Section component
  • Add PropTypes for the components
  • Add Storybook story
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Jun 30, 2022
@niloysikdar niloysikdar self-assigned this Jun 30, 2022
@niloysikdar niloysikdar moved this to In Progress in React Email Jun 30, 2022
@niloysikdar niloysikdar moved this from In Progress to Todo in React Email Jun 30, 2022
@niloysikdar niloysikdar moved this from Todo to In Progress in React Email Jun 30, 2022
niloysikdar added a commit that referenced this issue Jun 30, 2022
add column component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jun 30, 2022
add section component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jun 30, 2022
fixed email component with updated tags

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jun 30, 2022
fix email stories with the updated component structure

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jun 30, 2022
add missing stories for column component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jun 30, 2022
add stories for section component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 3, 2022
fix the structure of Email, Section and Column components

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 3, 2022
fix Email stories with the new structure

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 3, 2022
fix Section stories with new structure

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 3, 2022
fix Column stories

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 3, 2022
export props for components from the library

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 3, 2022
fix Email component with classes

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 3, 2022
fix types using Record and add styles to the prop for Email component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 3, 2022
fix types to use Record and add styles props for Column component
fix stories for Column with styles

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 4, 2022
fix types to use Record and add styles props for Column component
fix stories for Column with styles

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
niloysikdar added a commit that referenced this issue Jul 4, 2022
fix types with extends BaseStyleProp and adding classes to the props list

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
agentmilindu pushed a commit that referenced this issue Jul 4, 2022
* feat(component): add column

add column component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* feat(component): add section

add section component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* fix(component): fix email component

fixed email component with updated tags

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* docs(storybook): fix email stories

fix email stories with the updated component structure

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* docs(storybook): add stories for column

add missing stories for column component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* docs(storybook): stories for section

add stories for section component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* ci(storybook): fix storybook.yml

fix storybook.yml script to only deploy when push to main branch

Signed-off-by: Niloy Sikdar <[email protected]>

* fix(components): fix Email, Section, Column

fix the structure of Email, Section and Column components

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* docs(storybook): fix Email stories

fix Email stories with the new structure

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* docs(storybook): fix Section stories

fix Section stories with new structure

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* docs(storybook): fix Column stories

fix Column stories

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* feat(props): export props

export props for components from the library

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* fix(component): fix Email component

fix Email component with classes

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* fix(types): fix types props for Email

fix types using Record and add styles to the prop for Email component

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* fix(types): fix types and props for Column

fix types to use Record and add styles props for Column component
fix stories for Column with styles

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>

* fix(component): fix types and props name

fix types with extends BaseStyleProp and adding classes to the props list

resolves #39

Signed-off-by: Niloy Sikdar <[email protected]>
Repository owner moved this from In Progress to Done in React Email Jul 4, 2022
github-actions bot pushed a commit that referenced this issue Jul 5, 2022
# [1.1.0](v1.0.1...v1.1.0) (2022-07-05)

### Features

* **component:** add button component ([#47](#47)) ([c846451](c846451)), closes [#40](#40) [#40](#40) [#40](#40) [#40](#40)
* **component:** add column and section ([#46](#46)) ([c89ad5e](c89ad5e)), closes [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39) [#39](#39)
@agentmilindu agentmilindu moved this from Done to Released in React Email Jul 6, 2022
@agentmilindu agentmilindu added this to the GSoC 2022 - Sprint C milestone Jul 6, 2022
@agentmilindu agentmilindu added the 3 3 story points label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 3 story points GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

2 participants