Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what needs to be required first #10

Closed
tmaier opened this issue Jan 3, 2014 · 2 comments
Closed

Clarify what needs to be required first #10

tmaier opened this issue Jan 3, 2014 · 2 comments

Comments

@tmaier
Copy link

tmaier commented Jan 3, 2014

You mention to add require unobtrusive_flash and require unobtrusive_flash_bootstrap to application.js.

This is right in general.

But it took me a while to understand that order matters. require unobtrusive_flash must be after all functions which want to bind to this event.

require unobtrusive_flash_bootstrap
require unobtrusive_flash
@leonid-shevtsov
Copy link
Owner

Could you update to v3.0.0 and check if the documented load order works? I delayed the firing of flash rendering, so the script should have time to bind.

@tmaier
Copy link
Author

tmaier commented Mar 20, 2014

The right order is as of v3.0.0

//= require unobtrusive_flash
//= require unobtrusive_flash_bootstrap

This looks more logical. Thank you.

@tmaier tmaier closed this as completed Mar 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants