mitigate deprecation warnings #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newer versions of moment.js print this warning to the console:
```
moment().add('h',3)
Deprecation warning: moment().add(period, number) is deprecated. Please use moment().add(number, period).
moment().subtract('d',3)
Deprecation warning: moment().subtract(period, number) is deprecated. Please use moment().subtract(number, period).
```
|
Thinking about this PR I came to the conclusion that it might be not that good to break interoperability with older versions of moment.js. |
|
I know this is an old PR and this repository is clearly dead, but since this PR is still open I'll take the liberty to comment on it. I think this plugin needs versioning first so that calls like that can be made. "momentjs-business x.x" is only compatible with "moment x.x". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newer versions of moment.js print this warning to the console: