Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http and switch to json_schema #498

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

buraktabn
Copy link
Contributor

json_schema2 is discontinued. It's recommended to replace with json_schema.

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.48%. Comparing base (591782e) to head (152f4aa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...bstrate_metadata/lib/utils/spec_version_maker.dart 50.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   48.48%   48.48%           
=======================================
  Files         181      181           
  Lines        9588     9592    +4     
=======================================
+ Hits         4649     4651    +2     
- Misses       4939     4941    +2     
Flag Coverage Δ
polkadart 15.89% <ø> (ø)
polkadart_cli 12.04% <ø> (ø)
polkadart_keyring 65.24% <ø> (ø)
polkadart_scale_codec 54.93% <ø> (ø)
secp256k1_ecdsa 89.60% <ø> (ø)
sr25519 85.91% <ø> (ø)
ss58 96.87% <ø> (ø)
substrate_bip39 56.37% <ø> (ø)
substrate_metadata 87.66% <50.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bstrate_metadata/lib/utils/spec_version_maker.dart 41.66% <50.00%> (+1.04%) ⬆️
---- 🚨 Try these New Features:

@leonardocustodio
Copy link
Owner

Lgtm, thank you for the contribution

@leonardocustodio leonardocustodio merged commit e965696 into leonardocustodio:main Nov 20, 2024
15 checks passed
@leonardocustodio
Copy link
Owner

@all-contributors please add @buraktabn for code

Copy link
Contributor

@leonardocustodio

I've put up a pull request to add @buraktabn! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants