[polkadart_cli] generate method for getting a storage's key #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 44.84% 44.73% -0.11%
==========================================
Files 146 146
Lines 8230 8250 +20
==========================================
Hits 3691 3691
- Misses 4539 4559 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
clangenb
force-pushed
the
cl/generate-subscribe-storage
branch
from
2e67e32 to
12c3fef
Compare
|
If you have some free time would you mind taking a look at this one @Lohann ? |
clangenb
force-pushed
the
cl/generate-subscribe-storage
branch
from
3380de9 to
9c015cb
Compare
leonardocustodio
approved these changes
Nov 29, 2023
|
Released under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consider this as an intermediate step to generating code for storage subscriptions, which will take me some more time to learn about generating code before I could implement this. I am not sure how useful it is on its own yet. Regardless, I thought I will file a PR and let you judge. :)