Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all trimSpaces options, and expose jar scan filter options. #211

Conversation

jpmsilva
Copy link
Contributor

This PR exposes all trimSpaces options.
Previously it was a simple boolean, but Tomcat actually supports 4 different options - true, false, single and extended.
The default value if no other value is supplied remains false for backward compatibility.

Exposed configuration options tldSkip, tldScan and defaultTldScan that are passed to the jar scan filter that is used to process JARs that might contain TLD files. This can be used to speed up the build.

Finally, added support to redirect the JULI log API that Jasper uses to Maven's own log (SLF4J).
This results in a cleaner log trace for the build.

Also added support for redirecting JspC logs to the maven logger.
@leonardehrenfried leonardehrenfried merged commit e4a1477 into leonardehrenfried:master Feb 14, 2024
4 checks passed
@leonardehrenfried
Copy link
Owner

leonardehrenfried commented Feb 14, 2024

This has been released as 4.2.0. Thanks for the contribution!

@jpmsilva jpmsilva deleted the trim-spaces-jar-scan-filter branch February 14, 2024 15:05
@jpmsilva
Copy link
Contributor Author

Wow, that was fast!

While I don't anticipate any issues with the JULI log redirection, do let me know if there are any issues related to logging, as they might be related to this change. If so, I can probably introduce a goal parameter to enable/disable the log bridge behavior.

Related to this change, shouldn't the documentation site be updated?
I'm not entirely sure how/when that happens, but do let me know if there is anything else I need to do in order to reflect changes to the goal parameters.

Thank you!

@leonardehrenfried
Copy link
Owner

Hmm, I actually pushed the updated documentation to the gh-pages branch but it seems to not have deployed correctly. I need to do more investigation.

@leonardehrenfried
Copy link
Owner

I took a look and I appeared to have misconfigured the site plugin so it doesn't produce the plugin docs anymore. Do you know how to do it, @jpmsilva ?

@jpmsilva
Copy link
Contributor Author

Hi @leonardehrenfried
I created PR #213 to fix that.
Further information regarding the change was added to it.
Hope it helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants