issue-104: skipJspc property (4.x branch) #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| * Set this to 'true' to bypass compilation of JSP sources. | ||
| */ | ||
| @Parameter(defaultValue = "false", property = "jspc.skip") | ||
| private boolean skipJspc; |
There was a problem hiding this comment.
Suggested change
| private boolean skipJspc; | |
| private boolean skip; |
I think we can leave out the jspc part which you can derive form the context.
| } | ||
| if ( skipJspc ) { |
There was a problem hiding this comment.
Suggested change
| if ( skipJspc ) { | |
| if ( skip ) { |
leonardehrenfried
requested changes
Dec 19, 2022
|
ok have made the suggested changes above ( and to the other PR if we end up creating a 3.x branch ) |
leonardehrenfried
approved these changes
Dec 20, 2022
|
This code has been released as version 4.0.1. Give it a few minutes to show up on Maven Central: https://repo1.maven.org/maven2/io/leonard/maven/plugins/jspc-maven-plugin/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow the plugin to be skipped by specifying
<skipJspc>true</skipJspc>in the<configuration>block, or by supplying-Djspc.skipon the commandline.