This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Multi-value counter support plus bug fixes. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is awesome. Removing label merging is reasonable, it was a WIP. |
leoluk
pushed a commit
that referenced
this pull request
Apr 3, 2019
This PR adds support for multi-value counter. `_max` is being appended to metrics that are derived from base counter types (making them unique). Counter types are also being explicitly mapped to prometheus metric types. Finally, limiting which counter types are being exposed as metrics (e.g. it doesn't make sense to expose counter types like `PERF_AVERAGE_BULK` ). This addresses issues #1, #10. This PR also fixes the following bug: - `perflib_system_system_up_time` converted to UNIX time (fixes #6) - Single instance counters should not have labels - Remove commas when mangling metric names - Remove `Total` instances Unfortunately, I had to comment out the label merging code because it causes a panic when the 230 (Process) object is enabled (see #7). I'm currently running this across ~600 Windows nodes, a mix of Windows Server 2016 and 2019.
leoluk
pushed a commit
that referenced
this pull request
Apr 3, 2019
This PR adds support for multi-value counter. `_max` is being appended to metrics that are derived from base counter types (making them unique). Counter types are also being explicitly mapped to prometheus metric types. Finally, limiting which counter types are being exposed as metrics (e.g. it doesn't make sense to expose counter types like `PERF_AVERAGE_BULK` ). This addresses issues #1, #10. This PR also fixes the following bug: - `perflib_system_system_up_time` converted to UNIX time (fixes #6) - Single instance counters should not have labels - Remove commas when mangling metric names - Remove `Total` instances Unfortunately, I had to comment out the label merging code because it causes a panic when the 230 (Process) object is enabled (see #7). I'm currently running this across ~600 Windows nodes, a mix of Windows Server 2016 and 2019.
This was referenced Apr 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multi-value counter.
_maxis being appended to metrics that are derived from base counter types (making them unique). Counter types are also being explicitly mapped to prometheus metric types. Finally, limiting which counter types are being exposed as metrics (e.g. it doesn't make sense to expose counter types likePERF_AVERAGE_BULK). This addresses issues #1, #10.This PR also fixes the following bug:
perflib_system_system_up_timeconverted to UNIX time (fixes perflib_system_system_up_time_total vs \System\System Up Time value #6)TotalinstancesUnfortunately, I had to comment out the label merging code because it causes a panic when the 230 (Process) object is enabled (see #7).
I'm currently running this across ~600 Windows nodes, a mix of Windows Server 2016 and 2019.