Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): use find-config package to locate config #20

Merged
merged 2 commits into from
Jan 11, 2016
Merged

Conversation

Guria
Copy link
Collaborator

@Guria Guria commented Jan 11, 2016

There is no need in creating symlink with postinstall script so it was removed.
Getting started instruction provides command to get config template.

closes #10
includes #19

@codecov-io
Copy link

Current coverage is 100.00%

Merging #20 into master will not affect coverage as of 4d9028e

@@            master     #20   diff @@
======================================
  Files            2       2       
  Stmts          193     224    +31
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            193     224    +31
  Partial          0       0       
  Missed           0       0       

Review entire Coverage Diff as of 4d9028e

Powered by Codecov. Updated on successful CI builds.

There is no need in creating symlink with postinstall script so it was removed.
Getting started instruction provides command to get config template.

closes #10
Guria added a commit that referenced this pull request Jan 11, 2016
feat(config): use find-config package to locate config
@Guria Guria merged commit 2916bf9 into master Jan 11, 2016
@Guria Guria deleted the issue-10 branch January 11, 2016 10:52
@leonardoanalista
Copy link
Member

For PR #20 use find-config package to locate config, Is this a breaking
I can't see the commit with breaking change footer?

@Guria
Copy link
Collaborator Author

Guria commented Jan 11, 2016

@leonardoanalista see latest comment in #10

@leonardoanalista
Copy link
Member

because this should bump the major version to 3 right?

@Guria
Copy link
Collaborator Author

Guria commented Jan 11, 2016

@leonardoanalista it doesn't breaks anything in fact

@leonardoanalista
Copy link
Member

great stuff! cheers

@Guria
Copy link
Collaborator Author

Guria commented Jan 11, 2016

I just made it to fit my needs :)

@leonardoanalista
Copy link
Member

The symlink and auto-file creation was a bit arguable. Jshint, eslint and others you have to create config file manually. Also now this module is more inclusive to Windows clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postinstall in dev env
3 participants