Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double backticks escaping is no longer required #67

Closed
RomanMinkin opened this issue Mar 13, 2019 · 2 comments · May be fixed by satoshinakamoto007/bitcore#1119
Closed

Double backticks escaping is no longer required #67

RomanMinkin opened this issue Mar 13, 2019 · 2 comments · May be fixed by satoshinakamoto007/bitcore#1119

Comments

@RomanMinkin
Copy link
Contributor

RomanMinkin commented Mar 13, 2019 •
edited
Loading

Double backticks escaping was introduced in 99aa05b to fix #23 , but it's no longer required since [email protected] has fixed it commitizen/cz-cli@5f7737f

Current code produces extra escaping for non win32 architectures:

feat(auth): CLOUD-1058 some \`stuff\`

Do you guys want me to open up a PR?
RomanMinkin pushed a commit to RomanMinkin/cz-customizable that referenced this issue Mar 13, 2019
fix: remove double escaping for backticks
1c5fa6e 
ISSUES CLOSED: leoforfree#67
RomanMinkin added a commit to RomanMinkin/cz-customizable that referenced this issue Mar 14, 2019
@RomanMinkin
fix: remove double escaping for backticks
f3504bd 
ISSUES CLOSED: leoforfree#67
RomanMinkin added a commit to RomanMinkin/cz-customizable that referenced this issue Mar 14, 2019
@RomanMinkin
fix: remove double escaping for backticks
0c81797 
ISSUES CLOSED: leoforfree#67
@RomanMinkin RomanMinkin mentioned this issue Mar 14, 2019
Merged
leonardoanalista pushed a commit that referenced this issue Mar 14, 2019
@RomanMinkin @leonardoanalista
fix: remove double escaping for backticks (#68)
7aef66f 
ISSUES CLOSED: #67
@leonardoanalista
Copy link
Member

🎉 This issue has been resolved in version 5.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@axiac
Copy link

axiac commented Oct 22, 2019

This issue is present again in version 6.2.0.
I cannot tell about the previous 6.x versions.

@satoshinakamoto007 satoshinakamoto007 mentioned this issue Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@leonardoanalista @axiac @RomanMinkin