chore: Clippy fixes

leo91000 · Dec 19, 2022 · 506f98c · 506f98c
1 parent 80d7fb5
commit 506f98c
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/crates/crontab_runner/src/backfill.rs b/crates/crontab_runner/src/backfill.rs
@@ -71,7 +71,7 @@ where
         unknown_identifiers,
     } = get_backfill_and_unknown_items(crontabs, &known_crontabs);
 
-    if unknown_identifiers.len() > 0 {
+    if !unknown_identifiers.is_empty() {
         insert_unknown_crontabs(
             executor.clone(),
             escaped_schema,
@@ -109,7 +109,7 @@ where
                 })
                 .collect();
 
-            if to_backfill.len() > 0 {
+            if !to_backfill.is_empty() {
                 debug!(nb_jobs = to_backfill.len(), at = ?ts, "cron:backfill");
                 schedule_cron_jobs(
                     executor.clone(),

diff --git a/crates/crontab_runner/src/sql.rs b/crates/crontab_runner/src/sql.rs
@@ -132,7 +132,7 @@ where
     query(&statement)
         .bind(serde_json::to_string(crontab_jobs)?)
         .bind(last_execution)
-        .bind(use_local_time.then(|| Local::now()))
+        .bind(use_local_time.then(Local::now))
         .execute(executor)
         .await?;
 
@@ -147,7 +147,7 @@ impl CrontabJob {
                 payload.insert(
                     "_cron".into(),
                     json!({
-                        "ts": format!("{:?}", ts),
+                        "ts": format!("{ts:?}"),
                         "backfilled": backfilled
                     }),
                 );

diff --git a/crates/crontab_runner/src/utils.rs b/crates/crontab_runner/src/utils.rs
@@ -1,7 +1,7 @@
 use chrono::{prelude::*, Duration};
 use once_cell::sync::Lazy;
 
-pub(crate) static DURATION_ZERO: Lazy<Duration> = Lazy::new(|| Duration::zero());
+pub(crate) static DURATION_ZERO: Lazy<Duration> = Lazy::new(Duration::zero);
 pub(crate) static ONE_MINUTE: Lazy<Duration> = Lazy::new(|| Duration::minutes(1));
 
 pub(crate) fn round_date_minute<Tz: TimeZone>(

diff --git a/crates/migrations/src/lib.rs b/crates/migrations/src/lib.rs
@@ -86,12 +86,12 @@ where
 
     let last_migration = match last_migration_query_result {
         Err(SqlxError::Database(e)) => {
-            let Some(code) = e.code() else { return Err(SqlxError::Database(e).into()); };
+            let Some(code) = e.code() else { return Err(SqlxError::Database(e)); };
 
             if code == "42P01" {
                 install_schema(executor.clone(), escaped_schema).await?;
             } else {
-                return Err(SqlxError::Database(e).into());
+                return Err(SqlxError::Database(e));
             }
 
             None

diff --git a/src/builder.rs b/src/builder.rs
@@ -127,11 +127,11 @@ impl WorkerOptions {
                 let de_payload = serde_json::from_str(&payload);
 
                 match de_payload {
-                    Err(e) => Err(format!("{:?}", e)),
+                    Err(e) => Err(format!("{e:?}")),
                     Ok(p) => {
                         let job_result = job_fn(ctx, p).await;
                         match job_result {
-                            Err(e) => Err(format!("{:?}", e)),
+                            Err(e) => Err(format!("{e:?}")),
                             Ok(v) => Ok(v),
                         }
                     }

diff --git a/src/sql/fail_job.rs b/src/sql/fail_job.rs
@@ -70,7 +70,7 @@ pub async fn fail_job(
 
 pub async fn fail_jobs(
     executor: impl for<'e> PgExecutor<'e>,
-    jobs: &Vec<Job>,
+    jobs: &[Job],
     escaped_schema: &str,
     worker_id: &str,
     message: &str,