Do not move properties across spread

[gajus]

See:

eslint/eslint#10715 (comment)

[hcharley]

This issue being open scares me away from using this project. This could have serious implications for anyone using this. Right?

[gajus]

This issue being open scares me away from using this project. This could have serious implications for anyone using this. Right?

Without this fix, the project is unusable in a codebase that uses spread.

[TSMMark]

This is unfortunate. Anyone have a branch where this is fixed and can submit a PR? Otherwise, any pointers on how to implement a fix? I'm no expert but I've written one autofixing eslint rule before, maybe I could take a stab at it.

[leo-buneev]

Hi folks,

I've personally used this project not on entire codebase, but on particular files, so didn't implement spread case properly.

Seeing as this is fairly popular request, will add handling for spread in new version this week.

But be aware that changing order of keys in some very rare cases may affect how your code works (I believe that's why autofix its not implemented in core eslint).

[piranna]

But be aware that changing order of keys in some very rare cases may affect how your code works (I believe that's why autofix its not implemented in core eslint).

That's true, but that's due to bad quality of code, you should not confide in objects traversal order.

[TSMMark]

@leo-buneev This is one of the most common lint offenses my team gets on CI – you will save us so much time ❤️ Thanks so much

[leo-buneev]

Should be fixed in 1.1.0, let me know if there are any problems.

[TSMMark]

@leo-buneev amazing, thank you!

I just reintroduced this plugin into a medium-sized React codebase and I can confirm it now works as intended. Thanks again