Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are placed incorrectly #22

Open
vikas-bansal-DisneyPH opened this issue Aug 7, 2020 · 1 comment
Open

Comments are placed incorrectly #22

vikas-bansal-DisneyPH opened this issue Aug 7, 2020 · 1 comment

Comments

@vikas-bansal-DisneyPH
Copy link

vikas-bansal-DisneyPH commented Aug 7, 2020

Hi @leo-buneev,

Its a beautiful eslint fixer however I have found a bug. Please help.

"eslint-plugin-sort-keys-fix": "^1.1.1",

Following input has been converted incorrectly.

INPUT

const getShowInformationUsingShowId = function (appConfig, showId) {
	return getRequest({
		url: appConstants.XYZ, // example comment
		headers: {},
		params: {
			id: showId,
		},
	});
};

OUTPUT


const getShowInformationUsingShowId = function (appConfig, showId) {
	return getRequest({
		// example comment
		headers: {},
		params: {
			id: showId,
		},
		url: appConstants.XYZ,
	});
};
@namnm
Copy link

namnm commented Aug 10, 2021

I fixed this in my fork and also some other critical bugs as well.
Look like this repo is not in maintenance anymore, if anyone still interested in this sort keys plugin please try mine: https://github.com/namnm/eslint-plugin-sort-keys

Install: eslint-plugin-sort-keys
Rule: sort-keys/sort-keys-fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants