Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add way to abort obsolete async computed promises #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Jan 3, 2024

Motivation:

  • AbortSignal is the standard way to pipe "cancellation" through async calls

@jansav
Copy link
Collaborator

jansav commented Jan 4, 2024

What's the use case for this? Description doesn't describe it enough so that I could understand.

Unit tests are written in very technical manner and therefore understanding the use case is hard. Lets describe the use case in unit tests to figure out the solution.

Is the motivation to abort promise when asyncComputed is unobserved? If so, the implementation doesn't do it.
However, that could be something that asyncComputed would do.

It would be preferrable that the change to TS would be in separate commit to make reviewing easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants