Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Lens Monaco Editor component to extensions-api #5264

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Expose Lens Monaco Editor component to extensions-api #5264

merged 2 commits into from
Apr 25, 2022

Conversation

ixrock
Copy link
Contributor

@ixrock ixrock commented Apr 21, 2022 •
edited
Loading

Screenshot 2022-04-21 at 15 49 41

Breaking change in extension's development process:

How to fix: (to avoid compilation errors/warnings)

npm install typescript -D or yarn add typescript (latest version TS recommended)

close #5094

@ixrock ixrock added the area/extension Something to related to the extension api label Apr 21, 2022
@ixrock ixrock added this to the 5.5.0 milestone Apr 21, 2022
@ixrock ixrock self-assigned this Apr 21, 2022
@ixrock ixrock requested a review from a team as a code owner April 21, 2022 13:05
@ixrock ixrock requested review from jansav and Iku-turso and removed request for a team April 21, 2022 13:05
@ixrock ixrock added the enhancement New feature or request label Apr 21, 2022
aleksfront
aleksfront reviewed Apr 22, 2022
View reviewed changes
Copy link
Contributor

@aleksfront aleksfront left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this errors trying to compile extension with new k8slens/extensions types:
Screenshot 2022-04-22 at 11 51 40

It points to the following line
new monaco line

@ixrock
Copy link
Contributor Author

ixrock commented Apr 22, 2022 •
edited
Loading

This happens because some extensions are using old typescript < 4.5 see: typescript release notes
So, since it affects only development process, runtime should work as before.
Moreover we agreed with @jakolehm that we should add our Lens release notes about it to help developers fix this issue faster.

aleksfront
aleksfront previously approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@aleksfront aleksfront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works with fresh (at least 4.5.0) typescript version.

@ixrock ixrock dismissed stale reviews from Nokel81 and aleksfront via a1201e3 April 22, 2022 18:58
@ixrock ixrock merged commit 11f3caf into master Apr 25, 2022
@ixrock ixrock deleted the extensions/export_monaco_editor branch April 25, 2022 11:29
@Nokel81 Nokel81 mentioned this pull request May 4, 2022
Merged
@ixrock ixrock mentioned this pull request May 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksfront aleksfront aleksfront approved these changes

@Nokel81 Nokel81 Nokel81 approved these changes

@jansav jansav Awaiting requested review from jansav jansav is a code owner automatically assigned from lensapp/lens-ide

@Iku-turso Iku-turso Awaiting requested review from Iku-turso Iku-turso is a code owner automatically assigned from lensapp/lens-ide

Assignees

@ixrock ixrock

Labels
area/extension Something to related to the extension api enhancement New feature or request
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

Expose Lens Monaco Editor component to public
3 participants
@ixrock @Nokel81 @aleksfront