Upgrade to webpack@5 #4894
Merged
Upgrade to webpack@5 #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman <[email protected]>
ixrock
added
enhancement
# Conflicts: # src/main/menu/menu.ts
…ompilation in `yarn compile:extension-types`
|
@lensapp/lens-maintainers PTAL, ready for review again. |
aleksfront
approved these changes
Feb 25, 2022
Nokel81
reviewed
Feb 25, 2022
| import * as vars from "./src/common/vars"; | ||
| import getTSLoader from "./src/common/getTSLoader"; | ||
| import CircularDependencyPlugin from "circular-dependency-plugin"; | ||
| import { iconsAndImagesWebpackRules } from "./webpack.renderer"; | ||
|
|
||
| const configs: { (): webpack.Configuration }[] = []; | ||
|
|
||
| configs.push((): webpack.Configuration => { | ||
| console.info("WEBPACK:main", vars); |
There was a problem hiding this comment.
Can you please fix this and the "WEBPACK:renderer" one too, just change it to be { ...vars }
Nokel81
approved these changes
Feb 25, 2022
|
I'll make a follow up PR to fix that minor issue. |
DmitriyNoa
pushed a commit
that referenced
this pull request
Mar 3, 2022
Signed-off-by: DmitriyNoa <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpack@5and all related loaders with latest versionswebpack-dev-serverproxying tolens-proxy@pmmmwh/react-refresh-webpack-pluginwithreact-refresh-typescriptto support HMRrevived from #4725 + #4867