Replace WorkloadsOverviewDetailRegistry with reactive solution #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansav
requested review from
aleksfront and
jim-docker
and removed request for
a team
jansav
force-pushed
the
workloads-overview-detail-registry
branch
from
349d86f to
627f37a
Compare
Nokel81
reviewed
Feb 4, 2022
src/renderer/components/+workloads-overview/detail-components.injectable.ts
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
jansav
force-pushed
the
workloads-overview-detail-registry
branch
from
627f37a to
9580a1e
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Iku-turso
previously approved these changes
Mar 3, 2022
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Janne Savolainen <[email protected]>
jansav
force-pushed
the
workloads-overview-detail-registry
branch
from
9580a1e to
eb5475b
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Iku-turso
approved these changes
Mar 4, 2022
aleksfront
approved these changes
Mar 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Janne Savolainen [email protected]
Closes #4816