Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows AllUsers installs not updating correctly #4390

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Fix windows AllUsers installs not updating correctly #4390

merged 1 commit into from
Nov 19, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Nov 19, 2021

Fixes #4324

@Nokel81 Nokel81 added bug Something isn't working area/windows blocker labels Nov 19, 2021
@Nokel81 Nokel81 requested a review from a team as a code owner November 19, 2021 14:53
@Nokel81 Nokel81 requested review from nevalla, jakolehm and jim-docker and removed request for a team November 19, 2021 14:53
@Nokel81 Nokel81 added this to the 5.3.0 milestone Nov 19, 2021
@jim-docker
Copy link
Contributor

building/testing...

jim-docker
jim-docker approved these changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@jim-docker jim-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me, though I could not reproduce the reported issue that this solves...

@Nokel81
Copy link
Collaborator Author

Nokel81 commented Nov 19, 2021 •
edited
Loading

Should be an improvement though.

@Nokel81 Nokel81 merged commit 8a1faa3 into master Nov 19, 2021
@Nokel81 Nokel81 deleted the issue-4324 branch November 19, 2021 19:35
@jim-docker jim-docker mentioned this pull request Nov 23, 2021
Merged
@Nokel81 Nokel81 mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-docker jim-docker jim-docker approved these changes

@nevalla nevalla Awaiting requested review from nevalla nevalla is a code owner automatically assigned from lensapp/lens-ide

@jakolehm jakolehm Awaiting requested review from jakolehm jakolehm is a code owner automatically assigned from lensapp/lens-ide

Assignees
No one assigned
Labels
area/windows blocker bug Something isn't working
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.

AutoUpdate Lens but it only uninstalls the old version
2 participants
@Nokel81 @jim-docker