Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Prometheus detection #4316

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Cleanup Prometheus detection #4316

merged 2 commits into from
Nov 23, 2021

Conversation

Nokel81
Copy link
Collaborator

@Nokel81 Nokel81 commented Nov 10, 2021

  • Only try each type once

  • Log all attempts only if they all fail

Signed-off-by: Sebastian Malton [email protected]

- Only try each type once

- Log all attempts only if they all fail

Signed-off-by: Sebastian Malton <[email protected]>
@Nokel81 Nokel81 added chore area/metrics All the things related to metrics labels Nov 10, 2021
@Nokel81 Nokel81 requested a review from a team as a code owner November 10, 2021 21:39
@Nokel81 Nokel81 requested review from nevalla and jim-docker and removed request for a team November 10, 2021 21:39
Signed-off-by: Sebastian Malton <[email protected]>
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nokel81 Nokel81 merged commit 5d172b8 into master Nov 23, 2021
@Nokel81 Nokel81 deleted the metrics-cleanup branch November 23, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics All the things related to metrics chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants