Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Before hook for onRun of Catalog entities #3911
Before hook for onRun of Catalog entities #3911
Changes from 31 commits
e2f5978
b9c485d
aed5760
22787a1
4ebbccb
184612e
7cb1219
74ba7ed
9ed5b98
b18ab31
2484b89
ddbee47
265b648
8b7080e
6a0e4d3
daed2aa
21272f7
0f63ccb
cfdb4c9
a9e6d8b
a877e10
613f84b
6fe1809
c053286
f0b8479
bbde39e
fcdd032
d65e970
2ba9315
24f5f99
807aefd
74eb89c
c863134
44a8824
c264d5f
87babc8
fe212ad
5c3337c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should pass this in as props, we should have an unexported function that takes an
CatalogEntity
and does the work once (DRY as it were).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the refactoring be another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two checks can be combined:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, but with less readability IMHO.