Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Merge alpha on beta #94

Merged
merged 6 commits into from
Aug 30, 2023
Merged

feat!: Merge alpha on beta #94

merged 6 commits into from
Aug 30, 2023

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Aug 30, 2023

Closes #

Description of the changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Technical highlight/advice

jonas-martinez and others added 6 commits August 17, 2023 10:14
* feat: Oauth register/login implementation

* Fetch the id and secret from environment

* Use other library

* Use params for clientId, redirectUrl and scopes

* More work

* Fix auth

* More work

* Update user role

* add comments

* remove cgu and role handling

* Remove useless code

* ??? How to handle properly these variables

* Use root widget instead of guard for authentication check

* fix analyze

* fix

* Trying to check token at first start to avoid showing login page

* some fixes

* Add lenra report mode

* Remove useless code

* Put back the check dev

* add isnotdev

* missing methods

* Trying some things

* todo

* This will be much better

* More work

* This is working nicely

* show error to console

* Add comment

* Cleaning the project

* fix analyze

* fix review

* fix review

* refactor: Guards

---------

Co-authored-by: Thomas DA ROCHA <[email protected]>
* fix: Use Catcher dependency from fork

* fix flutter version in CI

* update flutter and sdk requirements
…more specific (#93)

* feat: OAuth Page Design

* This is much better

* Add media query

* Move everything in backoffice
@jonas-martinez jonas-martinez self-assigned this Aug 30, 2023
@jonas-martinez jonas-martinez added the enhancement New feature or request label Aug 30, 2023
@taorepoara taorepoara merged commit 0b78918 into beta Aug 30, 2023
19 checks passed
@taorepoara taorepoara deleted the alpha branch August 30, 2023 12:51
taorepoara added a commit that referenced this pull request Sep 29, 2023
* feat!: Oauth register/login implementation (#88)

* feat: Oauth register/login implementation

* Fetch the id and secret from environment

* Use other library

* Use params for clientId, redirectUrl and scopes

* More work

* Fix auth

* More work

* Update user role

* add comments

* remove cgu and role handling

* Remove useless code

* ??? How to handle properly these variables

* Use root widget instead of guard for authentication check

* fix analyze

* fix

* Trying to check token at first start to avoid showing login page

* some fixes

* Add lenra report mode

* Remove useless code

* Put back the check dev

* add isnotdev

* missing methods

* Trying some things

* todo

* This will be much better

* More work

* This is working nicely

* show error to console

* Add comment

* Cleaning the project

* fix analyze

* fix review

* fix review

* refactor: Guards

---------

Co-authored-by: Thomas DA ROCHA <[email protected]>

* fix: Use Catcher dependency from fork (#89)

* fix: Use Catcher dependency from fork

* fix flutter version in CI

* update flutter and sdk requirements

* feat: Add OAuth client id in config (#91)

* feat: Add dynamic oauth base and redirect url (#92)

* fix: OAuth dynamic vars

* feat!: Move OAuth page & guards into `backoffice` and `client` to be more specific (#93)

* feat: OAuth Page Design

* This is much better

* Add media query

* Move everything in backoffice

---------

Co-authored-by: Thomas DA ROCHA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants