Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome 5 SVGs #94

Open
pikesley opened this issue Apr 2, 2018 · 3 comments
Open

FontAwesome 5 SVGs #94

pikesley opened this issue Apr 2, 2018 · 3 comments

Comments

@pikesley
Copy link

pikesley commented Apr 2, 2018

FontAwesome 5 SVGs don't work out-the-box. I hacked it, though:

https://gist.github.com/pikesley/0197f9ea8aff737e6b80c945f741d584

@KristopherWagner
Copy link

this didn't work for me, when I do prefix: fa icon: info-circle and extraClasses: fas it makes the class fas fa fa-info-circle which doesn't work because there is an extra fa

Rudloff added a commit to Rudloff/openvegemap that referenced this issue Dec 10, 2018
Force onsenui 2.10.4 because 2.10.5 uses FontAwesome 5 and it is not compatible with awesome-markers
(see lennardv2/Leaflet.awesome-markers#94)
@KristjanESPERANTO
Copy link

KristjanESPERANTO commented Mar 22, 2019

FontAwesome 5 SVGs don't work out-the-box. I hacked it, though:

Thanks! This works. :-)

Rudloff added a commit to Rudloff/openvegemap that referenced this issue Oct 2, 2019
This upgrades fontawesome as well

Because of lennardv2/Leaflet.awesome-markers#94, whe have to use slightly
different icons
@Arch4060
Copy link

this didn't work for me, when I do prefix: fa icon: info-circle and extraClasses: fas it makes the class fas fa fa-info-circle which doesn't work because there is an extra fa

In addition to that you have to adapt leaflet.awesome-markers.js to get rid of the additional 'fa' from:

return "<i " + iconColorStyle + "class='" + options.extraClasses + " " + options.prefix + " " + iconClass + " " + iconSpinClass + " " + iconColorClass + "'></i>";

to (delete options.prefix)

return "<i " + iconColorStyle + "class='" + options.extraClasses + " " + iconClass + " " + iconSpinClass + " " + iconColorClass + "'></i>";

georgettodd added a commit to georgettodd/openvegemap that referenced this issue Apr 13, 2022
Force onsenui 2.10.4 because 2.10.5 uses FontAwesome 5 and it is not compatible with awesome-markers
(see lennardv2/Leaflet.awesome-markers#94)
georgettodd added a commit to georgettodd/openvegemap that referenced this issue Apr 13, 2022
This upgrades fontawesome as well

Because of lennardv2/Leaflet.awesome-markers#94, whe have to use slightly
different icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants