Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in attachment serialization functions #1

Conversation

kentbull
Copy link

@kentbull kentbull commented Nov 7, 2023

For ACDCs and anchors

Comment on lines 169 to 177
let pcnt = new Counter({
code: CtrDex.AttachedMaterialQuadlets,
count: Math.floor(atc.length / 4)
})
let msg = new Uint8Array(pcnt.qb64b.length + atc.length)
msg.set(pcnt.qb64b)
msg.set(atc, pcnt.qb64b.length)

return atc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't return msg?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, yes, it should return msg. I'll fix that now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated this with a force push

@kentbull kentbull force-pushed the single-issuer-holder-ipex-script branch from 56b62ed to 48f4a8c Compare November 8, 2023 01:34
@lenkan lenkan marked this pull request as ready for review November 8, 2023 08:44
@lenkan lenkan merged commit d966d45 into lenkan:single-issuer-holder-ipex-script Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants