Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

Replace multi_json with standard library json #83

Merged
merged 8 commits into from
Apr 20, 2015

Conversation

sferik
Copy link
Contributor

@sferik sferik commented Apr 17, 2015

I’ve recently made the same change in simplecov itself: simplecov-ruby/simplecov@ba6af08. As a former maintainer of multi_json, I can attest that it is not necessary here and not worth the overhead of an additional dependency, since json was added to the standard library in Ruby 1.9.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 07d6bf9 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 07d6bf9 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) to 91.29% when pulling 07d6bf9 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) to 91.29% when pulling 07d6bf9 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) to 91.29% when pulling 07d6bf9 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) to 91.29% when pulling 07d6bf9 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.57%) to 85.37% when pulling ee45d1d on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@sferik sferik force-pushed the replace-multi_json-with-json branch from ee45d1d to 07d6bf9 Compare April 17, 2015 13:55
@sferik
Copy link
Contributor Author

sferik commented Apr 17, 2015

Not sure why Travis is passing on every Ruby version except 2.2.0. I’ve tested it locally on on Ruby 2.2.2 and everything passes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 8acff04 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 8acff04 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@sferik
Copy link
Contributor Author

sferik commented Apr 17, 2015

Okay, the build is green now. This should be good to merge.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 799ef1d on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 799ef1d on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 799ef1d on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 799ef1d on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 799ef1d on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.19%) to 90.75% when pulling c511055 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@sferik sferik force-pushed the replace-multi_json-with-json branch from c511055 to 9ab0e5b Compare April 18, 2015 17:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.19%) to 90.75% when pulling 9ab0e5b on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 9ab0e5b on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@sferik sferik force-pushed the replace-multi_json-with-json branch from 9ab0e5b to d5d234f Compare April 18, 2015 17:33
@coveralls
Copy link

Coverage Status

Coverage decreased (-6.4%) to 84.55% when pulling d5d234f on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@sferik sferik force-pushed the replace-multi_json-with-json branch from d5d234f to ee99936 Compare April 18, 2015 17:37
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling ee99936 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.4%) to 84.55% when pulling ee99936 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@sferik sferik force-pushed the replace-multi_json-with-json branch from ee99936 to ad06d68 Compare April 18, 2015 17:43
@coveralls
Copy link

Coverage Status

Coverage decreased (-6.4%) to 84.55% when pulling ad06d68 on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@sferik sferik force-pushed the replace-multi_json-with-json branch from ad06d68 to 98446eb Compare April 18, 2015 17:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 98446eb on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.94% when pulling 98446eb on sferik:replace-multi_json-with-json into bb40b39 on lemurheavy:master.

@sferik sferik mentioned this pull request Apr 19, 2015
nickmerwin added a commit that referenced this pull request Apr 20, 2015
Replace multi_json with standard library json
@nickmerwin nickmerwin merged commit 99cf168 into lemurheavy:master Apr 20, 2015
@nickmerwin
Copy link
Member

Looks great, thank you as always @sferik!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants