This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 118
Replace multi_json with standard library json #83
Merged
nickmerwin
merged 8 commits into
lemurheavy:master
from
sferik:replace-multi_json-with-json
Apr 20, 2015
Merged
Replace multi_json with standard library json #83
nickmerwin
merged 8 commits into
lemurheavy:master
from
sferik:replace-multi_json-with-json
Apr 20, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
3 similar comments
sferik
force-pushed
the
replace-multi_json-with-json
branch
from
April 17, 2015 13:55
ee45d1d
to
07d6bf9
Compare
Not sure why Travis is passing on every Ruby version except 2.2.0. I’ve tested it locally on on Ruby 2.2.2 and everything passes. |
1 similar comment
Okay, the build is green now. This should be good to merge. |
4 similar comments
sferik
force-pushed
the
replace-multi_json-with-json
branch
from
April 18, 2015 17:29
c511055
to
9ab0e5b
Compare
sferik
force-pushed
the
replace-multi_json-with-json
branch
from
April 18, 2015 17:33
9ab0e5b
to
d5d234f
Compare
sferik
force-pushed
the
replace-multi_json-with-json
branch
from
April 18, 2015 17:37
d5d234f
to
ee99936
Compare
sferik
force-pushed
the
replace-multi_json-with-json
branch
from
April 18, 2015 17:43
ee99936
to
ad06d68
Compare
sferik
force-pushed
the
replace-multi_json-with-json
branch
from
April 18, 2015 17:48
ad06d68
to
98446eb
Compare
1 similar comment
Closed
nickmerwin
added a commit
that referenced
this pull request
Apr 20, 2015
Replace multi_json with standard library json
Looks great, thank you as always @sferik! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve recently made the same change in
simplecov
itself: simplecov-ruby/simplecov@ba6af08. As a former maintainer ofmulti_json
, I can attest that it is not necessary here and not worth the overhead of an additional dependency, sincejson
was added to the standard library in Ruby 1.9.