feat(handlers): add dragenter handler + preventDefaults + more tests + dragging class + debug hooks #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🆗 |
| // Check if type is accepted. | ||
| if (! accepts(scope.$eval(dropAccept), event)) return true; | ||
|
|
||
| removeDragOverClass(); | ||
| // Prevent default to accept drag and drop. | ||
| event.preventDefault(); |
There was a problem hiding this comment.
Pourquoi ne pas mettre ça au tout début de la fonction ?
There was a problem hiding this comment.
seulement si le drag&drop est accepté
|
Quelques remarques et ok. |
Yvem
changed the title
Yvem
force-pushed
the
yej-20150805-enhancements
branch
from
c08a9c6 to
95d141d
Compare
|
🆗 |
1 similar comment
|
🆗 |
|
Pas de label "mergeable" ? |
|
ce n'est pas le 8 ;) |
Yvem
added a commit
that referenced
this pull request
Aug 19, 2015
feat(handlers): add dragenter handler + preventDefaults + more tests + dragging class + debug hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added :
event.preventDefault();as requested in the specBy the way, updated the readme, cleaned some stuff, fixed #4 and partially #2