Add test detection with detective and some handy lisp commands to run the test on the REPL #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the commands lisp-test-run-buffer and lisp-test-run-current
|
Just when I finished doing this feature, I realize that @cxxxr had a similar idea about improving testing (https://github.com/lem-project/lem/pull/956/files), but I guess it has most of the job locally. So maybe we can combine both approaches. This one is clearly more static, using the available buffer information. I think it can be combine with a more package-base one so it's possible to run any test define on any package (with a simple selections prompts). Let me know what do you think 🙌 |
cxxxr
approved these changes
Aug 16, 2023
| (current-expression | ||
| (lem:with-point ((p point)) | ||
| (funcall | ||
| (variable-value 'lem/language-mode::beginning-of-defun-function :buffer) |
There was a problem hiding this comment.
I see that beginning-of-defunctions are exported.
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| (defun %default-capture (class position) | |||
| (let* ((line (str:split #\Space (line-string position))) | |||
| (name (second line))) | |||
| (name (str:replace-all ")" "" (second line)))) | |||
There was a problem hiding this comment.
I have learned from this that you don't necessarily have to write a serious parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lisp-test-run-bufferandlisp-test-run-current