Set last focused window in switch-to-window. #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxxxr
reviewed
Jul 26, 2023
src/internal-packages.lisp
Outdated
| @@ -203,6 +203,7 @@ | |||
| :*window-scroll-functions* | |||
| :*window-size-change-functions* | |||
| :*window-show-buffer-functions* | |||
| :*last-focused-window* | |||
There was a problem hiding this comment.
Maybe this variable should be encapsulated, what do you think?
There was a problem hiding this comment.
Or if you need to reference it from the outside package, maybe use the (last-focusd-window) function?
There was a problem hiding this comment.
Yes I think you are right. I'll export a (last-focused-window) function instead. It is only switch-to-last-focused-window which needs to access externally but I think it is best to keep the logic with the command.
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to switch to the repl and then use
switch-to-last-focused-windowto return to the buffer I was last editing. Currently the use ofswitch-to-last-focused-windowis limited because commands which switch windows are left to set*last-focused-window*themselves and most of them don't.To resolve this I added a line to set
*last-focused-window*in theswitch-to-windowfunction.The next step would be to make all the commands which directly call (setf (current window)) use
switch-to-windowso that*last-focused-window*is set andwindow-leave-hookis run.