Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a different path for refresh tokens #387

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Add support for a different path for refresh tokens #387

merged 2 commits into from
Dec 17, 2021

Conversation

theleewise
Copy link
Contributor

No description provided.

@jonathansamines
Copy link
Collaborator

Hey @theleewise, these changes look good. Please add some integration tests to verify the new configuration option works as expected.

@theleewise
Copy link
Contributor Author

😬 Oh man I'm not even sure where to even start with that. I have a basic understanding of writing tests but I'm at a bit of a loss on what to do here.

@jonathansamines Can you help or even point me in the right direction?

@jonathansamines
Copy link
Collaborator

Hey @theleewise you can look at this test in particular, I think it might be a good example to follow as it test exactly what you are doing here, except by overriding "tokenPath" (which is the only way right now of overriding the refresh tokens path)

test.serial('@refresh => creates a new access token with a custom token path', async (t) => {

Please let me know of any question you may have.

Copy link
Collaborator

@jonathansamines jonathansamines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for your contribution.

@jonathansamines jonathansamines merged commit 0ae8f47 into lelylan:master Dec 17, 2021
@jonathansamines
Copy link
Collaborator

Hi @theleewise. I released these changes as [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants