Merge pull request silverstripe#10763 from sunnysideup/patch-25

MINOR: faster checking if record exists
lekoala · May 5, 2023 · 1c2e1f8 · 1c2e1f8
2 parents 0978a43 + 9660652
commit 1c2e1f8
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/src/Security/Member.php b/src/Security/Member.php
@@ -924,15 +924,8 @@ public function inGroup($group, $strict = false)
         }
 
         $groupCandidateObjs = ($strict) ? $this->getManyManyComponents("Groups") : $this->Groups();
-        if ($groupCandidateObjs) {
-            foreach ($groupCandidateObjs as $groupCandidateObj) {
-                if ($groupCandidateObj->ID == $groupCheckObj->ID) {
-                    return true;
-                }
-            }
-        }
 
-        return false;
+        return $groupCandidateObjs->filter(['ID' => $groupCheckObj->ID])->exists();
     }
 
     /**