Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#290 implement Equatable #410

Merged
merged 7 commits into from
Feb 22, 2023
Merged

#290 implement Equatable #410

merged 7 commits into from
Feb 22, 2023

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Feb 18, 2023 •
edited
Loading

Addresses #290

Here I've added Equatable to Request, Response and PartValue. I've used the EquatableMixin method to avoid messing with any class inheritance.

@techouse techouse requested a review from JEuler February 18, 2023 13:47
@techouse techouse added the enhancement New feature or request label Feb 18, 2023
@techouse techouse marked this pull request as ready for review February 19, 2023 20:59
@techouse techouse requested a review from stewemetal February 19, 2023 21:00
@techouse techouse marked this pull request as draft February 19, 2023 21:02
@techouse techouse marked this pull request as ready for review February 19, 2023 21:26
@techouse techouse mentioned this pull request Feb 19, 2023
Closed
guy-plentific
guy-plentific approved these changes Feb 20, 2023
View reviewed changes
Copy link

@guy-plentific guy-plentific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JEuler
Copy link
Collaborator

JEuler commented Feb 22, 2023

Very cool, thank you soooo much. Should I prepare a release? :)

@techouse
Copy link
Collaborator Author

techouse commented Feb 22, 2023 •
edited
Loading

Sure, why not, probably something like v6.1.1

@JEuler
Copy link
Collaborator

JEuler commented Feb 22, 2023

Hoooray!

@JEuler
Copy link
Collaborator

JEuler commented Feb 22, 2023

Thank you Thank You!

@JEuler JEuler merged commit 253d69a into lejard-h:develop Feb 22, 2023
@techouse techouse deleted the issue-290-equatable branch February 22, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-plentific guy-plentific guy-plentific approved these changes

@JEuler JEuler JEuler approved these changes

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

Assignees

@JEuler JEuler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@techouse @JEuler @guy-plentific