Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable HttpLoggingInterceptor #399

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Configurable HttpLoggingInterceptor #399

merged 3 commits into from
Jan 6, 2023

Conversation

Guldem
Copy link
Contributor

@Guldem Guldem commented Jan 4, 2023

Updated the HttpLoggingInterceptor so users can specify a more fine grained logging level for there needs.

Inspired by the HttpLoggingInterceptor configuration of OkHttp.

Guldem added 2 commits January 4, 2023 09:54
@Guldem
Extracted the http logging interceptor
c342e51 
Make http logging interceptor configurable (none, basic, headers, body)
@Guldem
Minor tweaks
688f42c 
Updated documentation
@techouse
Copy link
Collaborator

techouse commented Jan 5, 2023 •
edited
Loading

Thanx for this! ♥️

Please resolve the change request/comment above.

@techouse techouse requested a review from JEuler January 5, 2023 18:43
@techouse techouse added the enhancement New feature or request label Jan 5, 2023
@Guldem
Simplified onRequest body and startMessage logic.
fe1e16e 
Made onResponse more consistent with onRequest.
@Guldem Guldem requested review from techouse and removed request for JEuler January 6, 2023 06:42
techouse
techouse approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@techouse techouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JEuler
JEuler approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@JEuler JEuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, many thanks!

@JEuler JEuler merged commit 7453582 into lejard-h:develop Jan 6, 2023
@Guldem Guldem deleted the feature/configurable_logging branch April 6, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techouse techouse techouse approved these changes

@JEuler JEuler JEuler approved these changes

Assignees

@JEuler JEuler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Guldem @techouse @JEuler