Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 3.0.6 #183

Merged
merged 32 commits into from
Oct 19, 2020
Merged

Deploy 3.0.6 #183

merged 32 commits into from
Oct 19, 2020

Conversation

lejard-h
Copy link
Owner

Deployment should me automated now #182

we'll see 😄

JEuler and others added 26 commits April 10, 2020 12:33
Runtime base url note update

Update faq.md
* Add optionalBody parameter to suppress warnings

Fixes #149

* Improve formatting

* Remove redundant _methodWithBody function

Use a single source of truth (the method's optionalBody property)

* Show optional body hint in warning message

* Make optionalBody configurable for all methods

Explicitly set the default value for every method

* Specify type for optionalBody argument

Co-authored-by: Wilko Manger <[email protected]>
@post(path: URL.DOCUMENT_PRIOR_INFO)
  Future<Response<T>> getPriorInfo<T>(@Body() Params params);

Which is usefull when single API method may respond differently
depending on request parameter values.

Co-authored-by: Aleksandr Malkov <[email protected]>
Version bumped

Removed Angular / Web examples

With nullability added

Update generator.dart

Dependency cleanup

Update pubspec.yaml

Update pubspec.yaml
Re add example removed here (https://github.com/lejard-h/chopper/pull/178/files)

Upgrade to Angular 6, but I had to remove jaguar_serializer which is not maintain anymore (last update 1 year ago).

Then use new Dart command to run pub, analyzer and formatter
@lejard-h lejard-h requested review from JEuler and stewemetal October 18, 2020 14:56
@codecov
Copy link

codecov bot commented Oct 18, 2020

Codecov Report

Merging #183 into master will decrease coverage by 0.26%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   89.45%   89.18%   -0.27%     
==========================================
  Files           5        5              
  Lines         332      333       +1     
==========================================
  Hits          297      297              
- Misses         35       36       +1     
Impacted Files Coverage Δ
chopper/lib/src/request.dart 91.46% <66.66%> (-1.04%) ⬇️
chopper/lib/src/utils.dart 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99632a8...85918f9. Read the comment docs.

@JEuler
Copy link
Collaborator

JEuler commented Oct 18, 2020

Let's see :D

@lejard-h lejard-h merged commit 5995c5c into master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants