Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
google_device
tonetwork_device
.ip_address
andport
fields fromDevice
constructor, they're only used in tests and add code complexity.Scanner changes
update_service
was inserting copies in devices list.remove_service
.Other changes
GoogleDevice
class withNetworkDevice
named tuple. It should really just hold the data, all checks are moved outside.Final
, they can be inferred automatically.Tested locally on my HA instance.