Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unconstrain zeroconf version #156

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Unconstrain zeroconf version #156

merged 1 commit into from
Sep 3, 2021

Conversation

KapJI
Copy link
Collaborator

@KapJI KapJI commented Sep 3, 2021 •
edited
Loading

This was added by dependabot in #60 with no particular reason.

HA Core uses the latest 0.36.2:

https://github.com/home-assistant/core/blob/70338da50efd6f5537fb8463ac42450bf7010e19/homeassistant/package_constraints.txt#L37

Tested locally that it still works.

@KapJI KapJI requested a review from leikoilja September 3, 2021 11:09
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Sep 3, 2021
leikoilja
leikoilja approved these changes Sep 3, 2021
View reviewed changes
Copy link
Owner

@leikoilja leikoilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, weird why did dependabot restricted it. Good to know so we could keen an eye for future dependabot actions.

Thanks

@leikoilja leikoilja merged commit 9d8de9c into leikoilja:master Sep 3, 2021
@KapJI KapJI deleted the unpin-zeroconf branch September 3, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leikoilja leikoilja leikoilja approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KapJI @leikoilja