Add exception for version #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 2 2
Lines 71 71
=======================================
Hits 42 42
Misses 27 27
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@ww-daniel-mora Thanks for submitting this change! Got one suggestion below otherwise this looks great. Thanks for including tests too.
|
Thanks @ww-daniel-mora ! |
|
@leighmcculloch thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current best practice for setting the version of a Go executable requires a global variable. This change adds a narrow exception for variables name Version exactly. It also adds tests to verify that and updates to README to explicitly state the permitted exceptions.