Merged from ILIAS #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into release_5-0 THIS IS A PULL ^^
smeyer-ilias
added a commit
that referenced
this pull request
Aug 27, 2015
smeyer-ilias
added a commit
that referenced
this pull request
Aug 27, 2015
fwolf-ilias
pushed a commit
that referenced
this pull request
Apr 28, 2016
smeyer-ilias
pushed a commit
that referenced
this pull request
Jun 28, 2017
smeyer-ilias
pushed a commit
that referenced
this pull request
Aug 25, 2017
adding missing dependencies
smeyer-ilias
pushed a commit
that referenced
this pull request
Apr 6, 2018
alex40724
pushed a commit
that referenced
this pull request
Nov 2, 2018
# This is the 1st commit message: ilCtrl: cleaned up uncommented code. we have vc. As `grep -r setTargetScript .` shows, the target script will always be ilias.php, so the dance with ilCtrl basically is a NOP (with runtime costs...). The ilCtrl::forwards method is private, returns no values and is only called in one location. The member variables parent and forward are only used in the forwards method. The two members are not used anywhere in the codebase as `grep -r "lCtrl->forward" .` and `grep -r "ilCtrl->parent" .` reveal. So we can just dump this. Removed deprecated addLocation/getLocations. The methods were deprecated 7 years ago. The last location were addLocation is used is Modules/LearningModule/classes/class.ilObjContentObjectGUI.php (in method addLocation). The last location where getLocations is used is Modules/LearningModule/classes/class.ilLMEditorGUI.php (in method displayLocator). # This is the commit message #2: ilCtrl: fixed overlooked merge conflict
alex40724
pushed a commit
that referenced
this pull request
Jul 10, 2019
smeyer-ilias
pushed a commit
that referenced
this pull request
Aug 5, 2019
Create own git hook document
smeyer-ilias
pushed a commit
that referenced
this pull request
Dec 4, 2019
tfamula
pushed a commit
that referenced
this pull request
Jan 6, 2020
alex40724
pushed a commit
that referenced
this pull request
Jan 28, 2020
smeyer-ilias
pushed a commit
that referenced
this pull request
Apr 16, 2020
…n object that implements Countable Fixing error by using ldap-user-sync. replace debug message after checking for an array ERROR-LOG: ilCronManager::runJob:95 count(): Parameter must be an array or an object that implements Countable ilCronManager::runJob:95 #0 ILIAS_PATH/Services/Init/classes/class.ilErrorHandling.php(461): Whoops\Run->handleError(2, 'count(): Parame...', 'ILIAS_PATH...', 387) #1 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(387): ilErrorHandling->handlePreWhoops(2, 'count(): Parame...', 'ILIAS_PATH...', 387, Array) #2 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPQuery.php(131): ilLDAPQuery->fetchGroupMembers() #3 ILIAS_PATH/Services/LDAP/classes/class.ilLDAPCronSynchronization.php(87): ilLDAPQuery->fetchUsers() #4 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(178): ilLDAPCronSynchronization->run() #5 ILIAS_PATH/Services/Cron/classes/class.ilCronManager.php(95): ilCronManager::runJob(Object(ilLDAPCronSynchronization), Array, true) #6 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(282): ilCronManager::runJobManual('ldap_sync') #7 ILIAS_PATH/Services/Cron/classes/class.ilCronManagerGUI.php(64): ilCronManagerGUI->confirmedRun() #8 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilCronManagerGUI->executeCommand() #9 ILIAS_PATH/Modules/SystemFolder/classes/class.ilObjSystemFolderGUI.php(152): ilCtrl->forwardCommand(Object(ilCronManagerGUI)) #10 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilObjSystemFolderGUI->executeCommand() #11 ILIAS_PATH/Services/Administration/classes/class.ilAdministrationGUI.php(250): ilCtrl->forwardCommand(Object(ilObjSystemFolderGUI)) #12 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(210): ilAdministrationGUI->executeCommand() #13 ILIAS_PATH/Services/UICore/classes/class.ilCtrl.php(175): ilCtrl->forwardCommand(Object(ilAdministrationGUI)) #14 ILIAS_PATH/ilias.php(20): ilCtrl->callBaseClass() #15 {main}
tfamula
pushed a commit
that referenced
this pull request
Nov 19, 2020
* TermsOfSerice: Apply PSR-2 coding style * TermsOfSerice: Apply PSR-2 coding style * TermsOfSerice: Apply PSR-2 coding style and other formattings * TermsOfSerice: Apply PSR-2 coding style and other formattings
M-Barz
pushed a commit
that referenced
this pull request
May 6, 2021
tfamula
pushed a commit
that referenced
this pull request
Nov 11, 2021
…ypes declarations, type hints, type properties Contact/classes added strict types #2 Contact/classes added strict types #3 Mail/Address added strict types Contact/classes Type Properties mail added strict types Services/Mail/classes addded strict types Services/Mail/classes added strict types + Services/Contact/ template type fix Services/Mail/classes added strict types 2 Services/Mail/classes added strict types 3 Services/Mail/classes added strict types 4 Services/Mail/classes added strict types 5 Services/Mail/classes added strict types 6 reverted changes to switch statements revert unwanted changes bugifx mixed default typ
smeyer-ilias
pushed a commit
that referenced
this pull request
Dec 14, 2021
alex40724
pushed a commit
that referenced
this pull request
May 4, 2022
Hi Fabian, a PHP Fatal Error occurs when performing setup command 'migrate': PHP Fatal error: Uncaught ILIAS\Setup\UnachievableException: Problem in DB-Update: 0 Return value of ilStaticCache::set() must be of the type bool, array returned in /***/trunk8/Services/GlobalCache/classes/Static/class.ilStaticCache.php:33#0 /***/trunk8/Services/GlobalCache/classes/class.ilGlobalCache.php(307): ilStaticCache->set() #1 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(62): ilGlobalCache->set() #2 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(29): ilCachedLanguage->writeToCache() #3 /***/trunk8/Services/Language/classes/class.ilCachedLanguage.php(107): ilCachedLanguage->__construct() #4 /***/trunk8/Services/Language/classes/class.ilLanguage.php(91): ilCachedLanguage::getInstance() #5 /***/trunk8/Services/Language/classes/class.ilLanguage.php(374): ilLanguage->__construct in /***/trunk8/Services/Database/classes/Setup/class.ilDatabaseUpdatedObjective.php on line 72
tfamula
pushed a commit
that referenced
this pull request
Jul 18, 2022
…getActiveOperationsOfRole(): Argument #2 ($a_role_id) must be of …"
tfamula
pushed a commit
that referenced
this pull request
Jul 18, 2022
…: Argument #2 ($a_value) must be of type string…"
tfamula
pushed a commit
that referenced
this pull request
Jul 18, 2022
… Argument #2 () must be of type string, null given
alex40724
pushed a commit
that referenced
this pull request
Jul 27, 2022
…sponseImage::__construct(): Argument #2 ($points) must be…"
alex40724
pushed a commit
that referenced
this pull request
Oct 17, 2022
tfamula
added a commit
that referenced
this pull request
Oct 21, 2022
smeyer-ilias
pushed a commit
that referenced
this pull request
Jul 20, 2023
schmitz-ilias
pushed a commit
that referenced
this pull request
Aug 15, 2023
tfamula
pushed a commit
that referenced
this pull request
Nov 2, 2023
alex40724
added a commit
that referenced
this pull request
Nov 2, 2023
alex40724
pushed a commit
that referenced
this pull request
Apr 23, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: #9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 #8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 #7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 #6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
tfamula
pushed a commit
that referenced
this pull request
Apr 26, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: #9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 #8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 #7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 #6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
tfamula
pushed a commit
that referenced
this pull request
Apr 30, 2024
…#7410) TypeError thrown with message "Return value of ilObjSurvey::getAnonymousIdByCode() must be of the type int, null returned" Stacktrace: #9 TypeError in /var/www/html/Modules/Survey/classes/class.ilObjSurvey.php:4702 #8 ilObjSurvey:getAnonymousIdByCode in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:175 #7 ilSurveyExecutionGUI:checkAuth in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:354 #6 ilSurveyExecutionGUI:outSurveyPage in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:280 #5 ilSurveyExecutionGUI:redirectQuestion in /var/www/html/Modules/Survey/Execution/class.ilSurveyExecutionGUI.php:140 #4 ilSurveyExecutionGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #3 ilCtrl:forwardCommand in /var/www/html/Modules/Survey/classes/class.ilObjSurveyGUI.php:206 #2 ilObjSurveyGUI:executeCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:199 #1 ilCtrl:forwardCommand in /var/www/html/Services/UICore/classes/class.ilCtrl.php:174 #0 ilCtrl:callBaseClass in /var/www/html/ilias.php:24
tfamula
pushed a commit
that referenced
this pull request
May 21, 2024
…eter #2 () of type string is deprecated
tfamula
pushed a commit
that referenced
this pull request
Jul 17, 2024
…ogger) must be of type ?ilLogger Mantis: https://mantis.ilias.de/view.php?id=41662
tfamula
pushed a commit
that referenced
this pull request
Jul 19, 2024
…ogger) must be of type ?ilLogger Mantis: https://mantis.ilias.de/view.php?id=41662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.