-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show total duration of video in video info panel #15
Comments
Hlo Lehnerpat I want to fix this issue, can you give me some description about that ):.... |
Hi @Yash-Var, thanks so much for taking an interest in this project :) This issue was actually blocked by #8 until earlier (I had a lot of unpushed commits because I wanted to do before-after comparisons of the UI overhaul), but I just pushed all my changes to the main branch. I'll take some time soon to add some more detail for you here, but if you want you can browse through the code and get familiar with it until then :) (Just a note: this is a hobby project for me, so the time I spend on it varies a lot, and I can't promise when I get around to responding to issues or add more explanations, hope you understand |
thanks @lehnerpat
…On Mon, May 30, 2022 at 12:48 AM lehnerpat ***@***.***> wrote:
Hi @Yash-Var <https://github.com/Yash-Var>, thanks so much for taking an
interest in this project :)
This issue was actually blocked by #8
<#8> until earlier (I
had a lot of unpushed commits because I wanted to do before-after
comparisons of the UI overhaul), but I just pushed all my changes to the
main branch.
I'll take some time soon to add some more detail for you here, but if you
want you can browse through the code and get familiar with it until then :)
(Just a note: this is a hobby project for me, so the time I spend on it
varies a lot, and I can't promise when I get around to responding to issues
or add more explanations, hope you understand
|
@lehnerpat can you give other issue which you want to fix ... |
@Yash-Var, so the idea here is to show the video's duration in the "Video Info" panel in editing mode: To get the duration, you need to react to an event on the video player (I'm not sure which, you'd have to check the documentation of the player we use: cookpete/react-player), add it to the state of the surround component (probably TrackPlayer), and pass it to the video info panel. The video player is integrated here: train-ride-maps/src/track-player/VideoPlayer.tsx Lines 10 to 19 in be748a8
The TrackPlayer component is over here:
BTW, #9 or #14 might be slightly easier issues to start with :) |
No description provided.
The text was updated successfully, but these errors were encountered: