Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total duration of video in video info panel #15

Open
lehnerpat opened this issue May 28, 2022 · 5 comments
Open

Show total duration of video in video info panel #15

lehnerpat opened this issue May 28, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@lehnerpat
Copy link
Owner

No description provided.

@lehnerpat lehnerpat added enhancement New feature or request good first issue Good for newcomers labels May 28, 2022
@Yash-Var
Copy link

Hlo Lehnerpat I want to fix this issue, can you give me some description about that ):....

@lehnerpat
Copy link
Owner Author

Hi @Yash-Var, thanks so much for taking an interest in this project :)

This issue was actually blocked by #8 until earlier (I had a lot of unpushed commits because I wanted to do before-after comparisons of the UI overhaul), but I just pushed all my changes to the main branch.

I'll take some time soon to add some more detail for you here, but if you want you can browse through the code and get familiar with it until then :)

(Just a note: this is a hobby project for me, so the time I spend on it varies a lot, and I can't promise when I get around to responding to issues or add more explanations, hope you understand ☺️)

@Yash-Var
Copy link

Yash-Var commented May 30, 2022 via email

@Yash-Var
Copy link

@lehnerpat can you give other issue which you want to fix ...

@lehnerpat
Copy link
Owner Author

@Yash-Var, so the idea here is to show the video's duration in the "Video Info" panel in editing mode:
image

To get the duration, you need to react to an event on the video player (I'm not sure which, you'd have to check the documentation of the player we use: cookpete/react-player), add it to the state of the surround component (probably TrackPlayer), and pass it to the video info panel.

The video player is integrated here:

<ReactPlayer
className="react-player"
controls
progressInterval={100}
width="100%"
height="100%"
url={videoUrl}
onProgress={onProgress}
config={{ playerVars: { start: 1, fs: 0 } }}
/>

The TrackPlayer component is over here:

export const TrackPlayer: FC<TrackPlayerProps> = ({ initialTrack }) => {


BTW, #9 or #14 might be slightly easier issues to start with :)

@lehnerpat lehnerpat removed the good first issue Good for newcomers label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants