Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default sources #159

Closed
alancleary opened this issue May 29, 2018 · 3 comments
Closed

Default sources #159

alancleary opened this issue May 29, 2018 · 3 comments
Assignees

Comments

@alancleary
Copy link
Contributor

Currently in the search and multi views, if no sources are provided as url query parameters then no data is loaded from any source, other than the query source in the case of the search view. This should be changed so that some source(s) are used by default when none are provided. Should this be the same as #155 where the first source in the list is used as default in the search or should all sources be used when none are provided?

@adf-ncgr
Copy link
Contributor

I think it's probably best to do it the way you had suggested (ie if no sources are selected, go ahead and search them all). One could imagine eventually making the query work the same way (ie if none specified, then ask them all), which might be appropriate and also use some of the same UI machinery needed if we decide to start allowing fuzzier querying ala #94.

@alancleary
Copy link
Contributor Author

@adf-ncgr Sounds good. Moving to stage.

@alancleary
Copy link
Contributor Author

Fixed in commit bb6d034.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants