Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default server #155

Closed
alancleary opened this issue May 9, 2018 · 3 comments
Closed

Default server #155

alancleary opened this issue May 9, 2018 · 3 comments
Assignees
@alancleary
Labels
bug enhancement

Comments

@alancleary
Copy link
Contributor

During the client refactor epic, the default server (LIS) that's used when the user doesn't specify a server was accidentally factored out. Let's factor it back in, but this time let's make it a field in the config file.
@alancleary alancleary self-assigned this May 9, 2018
@adf-ncgr
Copy link
Contributor

thinking about this again and out loud, perhaps we could simply introduce the convention that the first server listed in the config will be used at the default. I don't see a downside to doing so and it would avoid the need for a one-server site to do anything special.

@alancleary
Copy link
Contributor Author

Sounds reasonable.

@alancleary alancleary mentioned this issue May 29, 2018
Closed
@alancleary
Copy link
Contributor Author

Commit c93449a updated the AppConfig class to contain a method that returns the default server. For now, the server returned is the first in the list of servers loaded from the config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alancleary alancleary

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alancleary @adf-ncgr