[FIX] ImportError; [RFR] Apriori as json in upgrade_path #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
…using upgrade-path
6 tasks
yajo
reviewed
Dec 7, 2020
| @@ -97,14 +126,34 @@ def analyze(self): | |||
| } | |||
| ) | |||
|
|
|||
| if not self.upgrade_path: | |||
| return ( | |||
| "ERROR: no upgrade_path set when writing analysis of %s\n" % module_name | |||
There was a problem hiding this comment.
Shouldn't this raise instead of returning?
There was a problem hiding this comment.
no, we don't want to have a blocking error here. if upgrade_path is not accessible, the analysis will be written in a data field (log). (same behaviour as before).
|
|
||
| from .. import compare | ||
|
|
||
| _logger = logging.getLogger(__name__) | ||
| _IGNORE_MODULES = ["openupgrade_records", "upgrade_analysis"] | ||
|
|
||
|
|
||
| class Apriori(object): |
There was a problem hiding this comment.
I'd use a dataclass here. Not very important though.
This was referenced Dec 7, 2020
|
Hi @StefanRijnhart. Thanks a lot for the fixes. |
legalsylvain
added a commit
that referenced
this pull request
Dec 7, 2020
14.0 pr #4 without apriori
legalsylvain
pushed a commit
that referenced
this pull request
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.