Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add leetcode user -c that user can login with cookie #31

Merged
merged 3 commits into from
Dec 2, 2019
Merged

add leetcode user -c that user can login with cookie #31

merged 3 commits into from
Dec 2, 2019

Conversation

yihong0618
Copy link

Add a method that user can login with cookie relate to vscode-leetcode can't login problem

@yihong0618
Copy link
Author

Sorry I did not get the point of travis-ci error

@jdneo
Copy link

jdneo commented Nov 29, 2019

Thank you @yihong0618.

I'll take a look for this change recently. Probably on Sunday or next Monday.

@wanquanw
Copy link

wanquanw commented Dec 1, 2019

It seems like that the travis-ci errors are about code style problems.

@@ -39,6 +40,7 @@ Great thanks to leetcode.com, a really awesome website!

Read help first $ leetcode help
Login with your leetcode account $ leetcode user -l
Cookie login with cookie $ leetcode user -c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Align the indention?

@jdneo jdneo merged commit 126d550 into leetcode-tools:master Dec 2, 2019
@jdneo
Copy link

jdneo commented Dec 2, 2019

Thanks @yihong0618,

Do you need me to publish it now? I have no Windows machine on my side for now, so I cannot check my the CI job fails.

It would be great if you can help verify it. 😄

@yihong0618
Copy link
Author

Yes, please. And it seems that I can't find anything useful for the ci message. Sorry I did not find my error.
And I think in the vscode-leetcode side only need to add leetcode.cookieIn(maybe like leetcode.signIn just change password to cookie) is OK. But I think its a bad idea for solve the problem. LOL~

@jdneo
Copy link

jdneo commented Dec 2, 2019

@yihong0618 Hmm, can we open a webview to automatically get the cookie? The webview in VS Code could not achieve that because the VS Code team does not provide APIs to do that. I'm not sure if there is a easy-to-go solution in Node.js.

@jdneo
Copy link

jdneo commented Dec 2, 2019

2.6.17 released

@yihong0618
Copy link
Author

@jdneo
Seems hard but I can try ~. If the webview can load the whole login page will be nice.
I found this article may help, but to bypass the code not only need time and money, and the Headless Chrome is about 100MB, kind of not worth it

@jdneo
Copy link

jdneo commented Dec 3, 2019

Oh, that's a great article. thanks for sharing.

Yes I agree that if we need 100M more size to bypass it, there is no need to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants