Fix explicitly false booleans #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this change. I definitely support allowing a |
eugeneotto
force-pushed
the
fix-explicitly-false-booleans
branch
from
7952242
to
751f410
Compare
When a boolean option is explicitly set to `false`, e.g.: ```bash --option=false ``` it enters slop as the string value `'false'`. This commit updates the `BoolOption` option handler to interpret `'false'` and various other falsey values (`false`, `'false'`, `'no'`, `'off'`, `'0'`) as logically false.
eugeneotto
force-pushed
the
fix-explicitly-false-booleans
branch
from
751f410
to
1bcf46b
Compare
|
Thanks for the quick reply (and the great library)! I like that idea and updated the commit as suggested. I've also tweaked the README to document support for explicitly false boolean options. |
|
@eugeneotto this is excellent, thank you for the contribution! I'll get this pushed up as a bugfix release. (edit: released) |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 12, 2022
https://build.opensuse.org/request/show/1010068 by user coolo + dimstar_suse updated to version 4.9.3 see installed CHANGELOG.md v4.9.3 (2022-09-30) ------------------- Bug fixes: * Fix explicitly false boolean options and allow for additional false arguments [#276](leejarvis/slop#276) (Eugene Otto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a boolean option is explicitly set to
false, e.g.:it enters slop as the string value
'false'. This commit updates theBoolOptionoption handler to interpret'false'and various other falseyvalues (
false,'false','no','off','0') as logically false.